Skip to content

self nominate kannon92 for production readiness approval #5662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 7, 2025
Merged

self nominate kannon92 for production readiness approval #5662

merged 1 commit into from
Nov 7, 2025
+1 −0

Conversation

@kannon92
Copy link
Contributor

@kannon92 kannon92 commented Oct 20, 2025 •
edited
Loading

PRR example
#4566

Shadow contribution summary:

  • 1.33 shadow reviews:
    28
  • 1.34 shadow reviews: 30
  • 1.35 shadow reviews: 10

Planned future involvement:

  • 1.36 - I hope to take more reviews as an approver and help shadow.

Shadow reviewer promotion criteria:

Transitions from new to alpha

Transitions from alpha to beta

Transitions from beta to GA

Must have successfully reviewed at least three enhancements that require coordination between multiple components.

Must have successfully reviewed at least three enhancements that require version skew consideration (both HA and component skew): does behavior fail safely and eventually reconcile.

Must have successfully reviewed at least three enhancements that are outside your primary domain.

I would say my domain is sig-apps and sig-node.

Examples where the feature requires considering the case of administering thousands of clusters. This comes up frequently for host-based features in storage, node, or networking.

Examples where the feature requires considering the case of very large clusters. This is commonly covered by metrics.

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Oct 20, 2025
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Oct 20, 2025
@kannon92
Copy link
Contributor Author

kannon92 commented Oct 20, 2025

I'm still working on gathering the checklist so putting it in WIP for now.

@kannon92
Copy link
Contributor Author

kannon92 commented Oct 20, 2025

cc @deads2k @johnbelamaric @jpbetz @wojtek-t @soltysh

@kannon92 kannon92 changed the title WIP: self nominate kannon92 for production readiness approval self nominate kannon92 for production readiness approval Oct 20, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Oct 20, 2025
@deads2k
Copy link
Contributor

deads2k commented Nov 6, 2025

Great work Kevin. You've shadowed with me for two releases and handled some difficult situations and a large breadth KEPs.

+1

/approve
/hold

holding so other PRR approvers have a chance to review and comment too.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 6, 2025
soltysh
soltysh approved these changes Nov 6, 2025
View reviewed changes
Copy link
Contributor

@soltysh soltysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 from my side as well

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Nov 6, 2025
@jpbetz
Copy link
Contributor

jpbetz commented Nov 6, 2025

+1

Appreciate the attention to detail.

/lgtm

@wojtek-t
Copy link
Member

wojtek-t commented Nov 6, 2025

/lgtm

+1 for comments above - really solid and thorough work!

@johnbelamaric
Copy link
Member

johnbelamaric commented Nov 6, 2025

/approve

Welcome, Kevin!

@k8s-ci-robot
Copy link
Contributor

k8s-ci-robot commented Nov 6, 2025

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: deads2k, johnbelamaric, kannon92, soltysh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Nov 6, 2025
@kannon92
Copy link
Contributor Author

kannon92 commented Nov 7, 2025

Thanks everyone!

I think that's all the PRR approvers so I'm going to unhold.

/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 7, 2025
@k8s-ci-robot k8s-ci-robot merged commit 2a881c6 into kubernetes:master Nov 7, 2025
4 checks passed
@k8s-ci-robot k8s-ci-robot added this to the v1.35 milestone Nov 7, 2025
kannon92 added a commit to kannon92/org that referenced this pull request Nov 7, 2025
@kannon92
Add kannon92 to the team list in teams.yaml
23ea37d 
Since kubernetes/enhancements#5662 was accepted, I was told that I should add my name here.
@kannon92 kannon92 mentioned this pull request Nov 7, 2025
Merged
kannon92 added a commit to kannon92/org that referenced this pull request Nov 7, 2025
@kannon92
Add kannon92 to the team list in teams.yaml
a06fed5 
Since kubernetes/enhancements#5662 was accepted, I was told that I should add my name here.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@soltysh soltysh soltysh approved these changes

@johnbelamaric johnbelamaric Awaiting requested review from johnbelamaric

@palnabarun palnabarun Awaiting requested review from palnabarun

Assignees

@jpbetz jpbetz

@soltysh soltysh

@wojtek-t wojtek-t

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.

Projects

None yet

Milestone

v1.35

Development

Successfully merging this pull request may close these issues.

7 participants

@kannon92 @deads2k @jpbetz @wojtek-t @johnbelamaric @k8s-ci-robot @soltysh